[Backtracing] Fix threads=all in SWIFT_BACKTRACE parameters #86050
+52
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you added threads=all to the SWIFT_BACKTRACE settings, it actually prevented all threads from being shown. This fixes that. Also, the multiple thread test should test for presence of multiple threads. rdar://166532079
carlpeto
force-pushed
the
eng/PR-166532079
branch
from
fba6a83 to
590f3d7
Compare
Contributor
Author
|
@swift-ci please smoke test |
al45tair
approved these changes
Dec 15, 2025
Contributor
Author
|
@swift-ci please smoke test |
Contributor
Author
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you added threads=all to the SWIFT_BACKTRACE settings, it actually prevented all threads from being shown.
Note: the workaround is easy, the default if threads= is not specified is for all threads to be shown.
rdar://166532079